Double Session: Patch Reviews & Turning Regular People into Mentors

Click here to watch Double Session: Patch Reviews & Turning Regular People into Mentors.

Patch Reviews: Get good reviews, give good reviews. Faster.

There are over 2000 core issues waiting for reviews. We need more reviews faster. A shortage of timely reviews frustrates patch authors, leads to draining rerolls, and causes some would-be contributors to give up on core. Some reviews, like: “looks good”, lack specific useful information. When core committers review issues, they sometimes point out missing core gates requirements that could have been addressed before RTBC. This drags out the time to commit.


  1. Get more reviews.
  2. Get faster reviews.
  3. Get more useful reviews.

We will discuss ways accomplish those goals through:

  1. Patch authors asking for reviews in a way that guides potential reviewers into giving just the right kind of feedback, like:
    • asking for needs architectural review, needs usability review, needs coding standards review, needs manual testing, etc.,
    • using links to meta issues with review instructions, and
    • linking to reusable Contributor Task documents.
  2. More efficient reviews with tools like:
    • dreditor,
    • drush,
    • html (yes html),
    • screen capturing.
  3. More informative reviews, where the reviewer:
    • gives steps to reproduce in a numbered list (or steps that show it is not reproducible),
    • lists which browsers versions and theme and when to include that information,
    • references d.o documents when appropriate like sections of the standards, or the core gate requirements,
    • checks previous comments to identify concerns and state if the patch addresses them and which still need to be addressed, and
    • points out what is blocking versus non-blocking, and suggests what is to be done in a follow-up.

We won’t just provide lists of suggested things to do; we will discuss the motivation and benefits for the suggestions.

We can do these now. But dream: how can changes to embrace some of these concepts?

Who's it for?

This conversation is to help developers who want their patches reviewed faster, and for any contributors who want to be more effective and efficient with their reviews. Come share your techniques for patch review, and help us "close the loop" on core's review process.

Stories & strategies: turning regular people into mentors of mentors

One of the more daunting things we encounter in core development is getting enough people to regularly contribute. To be sustainable, we need to encourage new contributors to participate in core development. To that end, the Drupal Core Mentoring program seeks to engage new contributors and experienced developers alike to participate in the program. Mentoring provides participants with direction and encouragement to help them find their way in the maze of the Drupal issue queues.

This session is for anyone who would like to learn more about the mentoring program, learn to mentor new contributors, or is organizing their own sprints. We will learn about tools available to mentors, documentation, and practical techniques for mentoring newcomers. We’ll include strategies for how to

  • make sure people feel welcome
  • match tasks to participants
  • keep people engaged even when they struggle
  • help without being overbearing
  • answer questions you don’t know the answer to
  • enable folks to continue afterward on their own
Schedule Information
Experience level: 
Time slot: 
Tuesday · 13:00-14:00